src: allow empty --experimental-config-file#61610
Open
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Open
src: allow empty --experimental-config-file#61610marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
marco-ippolito
force-pushed
the
default-config-json
branch
2 times, most recently
from
775234b to
9b00ced
Compare
MoLow
approved these changes
Feb 1, 2026
marco-ippolito
added
the
semver-minor
github-actions
bot
removed
the
request-ci
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61610 +/- ##
==========================================
- Coverage 89.76% 89.75% -0.01%
==========================================
Files 673 674 +1
Lines 203944 204404 +460
Branches 39191 39275 +84
==========================================
+ Hits 183080 183473 +393
- Misses 13194 13236 +42
- Partials 7670 7695 +25
🚀 New features to boost your workflow:
|
marco-ippolito
force-pushed
the
default-config-json
branch
4 times, most recently
from
3dc9b42 to
2356e3a
Compare
pmarchini
reviewed
Feb 1, 2026
Comment on lines
-18
to
-19
| ['--experimental-config-file', 'node.config.json', ''], | ||
| ['--experimental-default-config-file', '', false], |
Member
There was a problem hiding this comment.
Why are we removing those entries in the test?
marco-ippolito
force-pushed
the
default-config-json
branch
from
2356e3a to
e53ba12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
--experimental-config-fileaccept no arg.When no arg is passed, it will default to
node.config.json.--experimental-default-config-fileis just an alias of--experimental-config-file.The reason for this change is so when stable we can just remove
--experimental-default-config-fileand rename--experimental-config-fileto--config-file.Users can execute node with
node --config-file index.jsornode --config-file=foo.json index.js.